Skip to content

azurerm_logic_app_standard: add default virtual_network_subnet_id value in update to bypass strict azure policies#29442

Closed
jiaweitao001 wants to merge 1 commit intohashicorp:mainfrom
jiaweitao001:logic_app_vnet_issue
Closed

azurerm_logic_app_standard: add default virtual_network_subnet_id value in update to bypass strict azure policies#29442
jiaweitao001 wants to merge 1 commit intohashicorp:mainfrom
jiaweitao001:logic_app_vnet_issue

Conversation

@jiaweitao001
Copy link
Copy Markdown
Collaborator

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Currently the update payload does not have virtual_network_subnet_id set if there's no change on this value. Some Azure polices requires this value to be set, so this PR adds a default value to the update payload to bypass this policy.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #29364

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

…ue in update to bypass strict azure policies
@SachaSmets
Copy link
Copy Markdown

Any updates on this?

@sreallymatt
Copy link
Copy Markdown
Collaborator

This was resolved by #30272. The Update function now retrieves the existing logic app and conditionally updates that payload, meaning that even without a change to virtual_network_subnet_id the subnet is present in the request.

@sreallymatt sreallymatt closed this Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

azurerm_logic_app_standard does not pass virtualNetworkSubnetId in rest api request when the virtual_network_subnet_id variable does not change

4 participants